refactor(parser): simplify parser test #16942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
xxchan
reviewed
May 27, 2024
Comment on lines
+171
to
+173
| let update = std::env::var("UPDATE_PARSER_TEST").is_ok(); | ||
| std::env::set_current_dir("tests/testdata").unwrap(); | ||
|
|
There was a problem hiding this comment.
What about relying on expect_test to update result?
risingwave/src/frontend/planner_test/src/lib.rs
Lines 95 to 98 in e16812b
There was a problem hiding this comment.
I find that it's not a good idea to use expect_test as it can not show diff one case at a time. Multiple cases would mix together. I'm going to revert this.
There was a problem hiding this comment.
I mainly just blindly update the tests and rely on git diff to see what's changed.
Signed-off-by: Runji Wang <[email protected]>
This reverts commit 29de738.
Signed-off-by: Runji Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR removes crate
sqlparser/test_runnerand merges its code into a single filesqlparser/tests/parser_test.rs. This way, these test cases can be included when runningcargo test -p risingwave_sqlparser.This PR also uses libtest-mimic for a better UI, removes multistage
apply-parser-test,do-apply-parser-test, and keepsupdate-parser-testonly.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.